Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag aria-checked on an input type=checkbox or radio #347

Closed
carmacleod opened this issue Mar 10, 2021 · 7 comments
Closed

Flag aria-checked on an input type=checkbox or radio #347

carmacleod opened this issue Mar 10, 2021 · 7 comments
Assignees
Labels
Bug Something isn't working development engine Issues in the accessibility-checker-engine component priority-2 (med) reproducible

Comments

@carmacleod
Copy link
Contributor

Flag aria-checked on an input type=checkbox or radio, as the element's default checked attribute / state always wins out anyway.

https://w3c.github.io/html-aria/tests/checked-test.html

This can either be a warning (telling the author that their aria-checked attribute is useless on input elements that allow the checked attribute) or a violation (telling the author not to do that).

@carmacleod carmacleod added the Bug Something isn't working label Mar 10, 2021
@tombrunet tombrunet added the engine Issues in the accessibility-checker-engine component label Apr 21, 2021
Copy link

Jun 1, 2021

As of June 1

  • general rule description (SME & Dev)
  • testcases written (Dev)
  • rule developed (Dev)
  • message written (SME)
  • help written (SME)

@scottaohara
Copy link

scottaohara commented Nov 21, 2021

ARIA in HTML (w3c/html-aria#372) is tightening the rule on use of aria-checked, particularly due to w3c/aria#1622 and the fact that aria-checked=mixed should never be able to be exposed by browsers that correctly follow the ARIA spec.

we would request that this at the very least this be called out as an author error if using aria-checked=mixed on a checkbox.

There is a bug in chromium now where aria-checked incorrectly takes precedent over the native checked / dirty checked state of an element, which can cause inaccurate information to be exposed if the checked state and the aria-checked attribute are out of alignment: https://bugs.chromium.org/p/chromium/issues/detail?id=1260371

@carmacleod
Copy link
Contributor Author

@MHoov Where can I find the "general rule description (SME & Dev)" and testcases that were written as of June 1? I don't know where to look.

@aliunwala
Copy link
Contributor

Notes from Triage Meeting:

If aria tag "overrides" the native elements state in an AT then this should be a violation.

According to a quick chrome test the aria tag overrides the native behavior. So we are expecting this to be a Violation.

@marcjohlic
Copy link
Member

@shunguoy
Copy link
Contributor

this might be expanded to a more generic case when a user explicitly specifies a role that is the same or conflicts with the implicit role.

@shunguoy shunguoy assigned shunguoy and unassigned carmacleod Mar 8, 2022
@shunguoy
Copy link
Contributor

shunguoy commented Mar 8, 2022

this will be covered in #721, close as fixed.

@shunguoy shunguoy closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working development engine Issues in the accessibility-checker-engine component priority-2 (med) reproducible
Projects
None yet
Development

No branches or pull requests

7 participants