Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading log message when app.yaml and appengine-web.xml file are missing #990

Open
peterjot opened this issue Aug 18, 2020 · 6 comments
Open

Misleading log message when app.yaml and appengine-web.xml file are missing #990

peterjot opened this issue Aug 18, 2020 · 6 comments
Labels
enhancement p3

Comments

@peterjot
Copy link

peterjot commented Aug 18, 2020 •
edited
Loading

If app.yaml and appengine-web.xml file are missing then we get "Detected App Engine app.yaml based application." log message. I think we could log another message in such case, because this one is misleading.

https://github.com/GoogleCloudPlatform/app-maven-plugin/blob/master/src/main/java/com/google/cloud/tools/maven/deploy/Deployer.java#L44
@jasinapj
Copy link

Maybe we could throw an exception if the xml and yaml configuration were not found? Right now the yaml stager is used in that case

@loosebazooka
Copy link
Contributor

Makes sense, and user contributions are always appreciated.

Copy link

Could I take this issue if you don't mind : )

@meltsufin
Copy link
Member

Sure.

Copy link

Sep 11, 2021 •
edited
Loading

Thanks @meltsufin , I'm working on it.

( Just out of curiosity, what's the meaning of label p4 )

PR has been filed, could you be so kind as to take a look on it ^_^

@chanseokoh chanseokoh mentioned this issue Sep 13, 2021
Closed
@elefeint
Copy link
Contributor

p4 means you don't have a deadline to finish the task :)

@JoeWang1127 JoeWang1127 transferred this issue from GoogleCloudPlatform/app-maven-plugin Jan 29, 2024
@zhumin8 zhumin8 added the p3 label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement p3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Throw exception when app.yaml doesn't exist cxorm/app-maven-plugin
8 participants
@suztomo @loosebazooka @zhumin8 @meltsufin @peterjot @elefeint @jasinapj