Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messy devicelist for Apple devices #3619

Open
Zandor300 opened this issue Oct 31, 2022 · 3 comments
Open

Messy devicelist for Apple devices #3619

Zandor300 opened this issue Oct 31, 2022 · 3 comments

Comments

@Zandor300
Copy link
Contributor

Zandor300 commented Oct 31, 2022 •
edited
Loading

The current devicelist for Apple devices is a bit messy, with different naming schemes for different devices. Some devices are separated by whether they have cellular or not and others aren't.

I think this could be cleaned up a bit by going through all devices and correcting the naming scheme. In this case, I would suggest the naming scheme that I used in the PR description. This is the naming scheme used by Apple:

  • iPad (10th generation)
  • iPad Pro (11-inch) (4th generation)
  • iPad Pro (12.9-inch) (6th generation)

Additionally, I think the cellular specification should be dropped from the devicelist and this should be its own metric that Countly keeps track of. Countly already keeps track of the carrier the user is using anyway.

I would volunteer to do this (cleaning up devicelist), but maybe renaming previously added devices is discouraged? What do you think?
@Zandor300 Zandor300 mentioned this issue Oct 31, 2022
Merged
@ar2rsawseen
Copy link
Member

Hello
I think the main problem, is that we actually need different names for different models.
If we use the same name, then when you break down data you would see different percentages for the same name (because underneath it breaks down data by the model, not the beautified name). That is why we tried to keep cellular specifications, to have at least some way to distinguish them visually

@Zandor300
Copy link
Contributor Author

@ar2rsawseen

I see. Personally when viewing the data generated from my iOS app (for this example), I don't care which version of the device the user is using. I would prefer to have all users of a device grouped. I think that would give a more accurate picture of what devices the user is using.

I use Countly mainly to look at which iOS versions and devices users are using so I can make a descision on whether to drop support for old iOS versions. iPhone 8 for example I have 2 versions showing using my app. I would prefer to have only 1 iPhone 8 entry with all users using any version of iPhone 8.

@ar2rsawseen
Copy link
Member

I understand that, and it would work for the community version
but for Enterprise one with data granularity, it is not possible to group that information in such a way, by display name, unfortunately.
so that is why we need separate names here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ar2rsawseen @Zandor300