Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up code #4

Open
1 of 3 tasks
AndyEveritt opened this issue Mar 10, 2020 · 3 comments
Open
1 of 3 tasks

Tidy up code #4

AndyEveritt opened this issue Mar 10, 2020 · 3 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers refactor Refactor code

Comments

@AndyEveritt
Copy link
Owner

AndyEveritt commented Mar 10, 2020 •
edited
Loading

  • Add docstrings
  • Update variable names to be more representative of what they are
  • Reduce big O
@AndyEveritt AndyEveritt added the refactor Refactor code label Mar 10, 2020
@AndyEveritt AndyEveritt linked a pull request Jun 17, 2020 that will close this issue
Reorganise #23
Merged
@AndyEveritt AndyEveritt removed a link to a pull request Jun 17, 2020
Reorganise #23
Merged
@AndyEveritt AndyEveritt added the documentation Improvements or additions to documentation label Jun 17, 2020
@AndyEveritt
Copy link
Owner Author

Most of the code is documented now.

However the Fusion API code could do with a huge refactor. This is not my area of expertise so help is welcome

@AndyEveritt AndyEveritt added the good first issue Good for newcomers label Jun 29, 2020
@PhilippeDataScienc
Copy link

Hi, I would like to help.
I'm in additiva manufacturing and code in python.
Where is the Fusion API code to refactor ?

@AndyEveritt
Copy link
Owner Author

Hi, the code is primarily in this file https://github.com/AndyEveritt/ASMBL/blob/master/src/fusion_api/Handlers.py but I believe Fusion have changed the API so you will need a paid Fusion licence to correctly test the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers refactor Refactor code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndyEveritt @PhilippeDataScienc