View source for Wikivoyage:Travellers' pub

== Why are our official inserted maps broken? ==

This has been reported to me by some students, and confirmed by me, see my sandbox [[User:Hanyangprofessor2/sandbox]].

The maps inserted from Insert->Map in visual editor do not display location pins. 

I.e. this is good code 

<nowiki>{{Mapframe|39.95|116.35|zoom=10|width=650|layer=M}}</nowiki>

and this is bad code

<nowiki><mapframe latitude="39.95" longitude="116.35" zoom="10" width="650" height="418" /></nowiki>

What's wrong? The layer is missing in the bad code, which perhaps could be the answer, but there is no way I can see to enable that parameter. Right now, I am telling my students to copy a map from another article it works in and adjust GPS coordinates manually, but it is a bit annoying that our official, nice, user-friendly way of inserting maps is effectively broken. [[User:Hanyangprofessor2|Hanyangprofessor2]] ([[User talk:Hanyangprofessor2|talk]]) 05:51, 23 September 2024 (UTC)

:Someone with more technical knowledge about the Mapframe template and element can probably add some nuance here, but I'll attempt to explain this issue to the best of my ability.
:The element (<code><nowiki><mapframe/></nowiki></code>) is one of the ingredients for rendering the template ({{tl|Mapframe}}) and its functionality. Other ingredients include [[Module:map]], which adds understanding of GeoJSON data. That processing of GeoJSON data is what makes markers (location pins) render on the map. It's not being called into action through the element - only through the template.
:The layer not being defined doesn't play a role here.
:On a sidenote, I can't seem to replicate the issue myself - that is, spawning the element instead of the template through the visual editor. As for fixes, you should be able to force the usage of {{tl|Mapframe}} in the visual editor by using Insert → Template and selecting Template:Mapframe through there though.
:I hope this helps. <span style="font-family:atkinson hyperlegible">― '''[[User:Wauteurz|Wauteurz]]''' <small>([[User talk:Wauteurz|talk]])</small></span> 11:54, 24 September 2024 (UTC)
::I assumed something like that, but in my reading of [[Mediawikiwiki:Help:Extension:Kartographer]], the &lt;mapframe> element indeed does render markers, if those are given as geoJSON – and [[Module:Marker]] seems to indeed produce geoJSON code. Does the element require the code to be included as content of the element itself? –[[User:LPfi|LPfi]] ([[User talk:LPfi|talk]]) 14:18, 24 September 2024 (UTC)
::: Anyway, using the template would be the right solution. –[[User:LPfi|LPfi]] ([[User talk:LPfi|talk]]) 14:21, 24 September 2024 (UTC)
::::@[[User:LPfi|LPfi]]: That does seem to be the case, yes! If you have a look at [[MW:Help:Extension:Kartographer#GeoJSON|#GeoJSON]] in the source editor, the mapframe element is started, raw GeoJSON data is inserted, and the mapframe is closed again. Using <code><nowiki><mapframe/></nowiki></code> as in the sandbox above, opens and closes the element without giving it opportunity to look for GeoJSON data to display. From what I can tell, the element also cannot work without being properly closed, and cannot look beyond its own extent for usable GeoJSON data (i.e., all markers have to be embedded within the mapframe element). 
::::In summary: <code><nowiki><mapframe/></nowiki></code> shouldn't be used in articles, as {{tl|Mapframe}} contains essential parts for ''gathering'' map markers that the element itself does not have. <br/><span style="font-family:atkinson hyperlegible">― '''[[User:Wauteurz|Wauteurz]]''' <small>([[User talk:Wauteurz|talk]])</small></span> 21:44, 25 September 2024 (UTC)
::Wauteurz, if you use <code>Insert > Map</code> in the visual editor, then it inserts the <code><nowiki><mapframe></nowiki></code> element directly, rather than the template. [[User:WhatamIdoing|WhatamIdoing]] ([[User talk:WhatamIdoing|talk]]) 20:01, 25 September 2024 (UTC)
:::Interesting. I tried both inserting a map and inserting a template through the Visual Editor. When I moved that edit into the source editor, that would convert to {{tl|Mapframe}} in both cases. I didn't publish any edits for my testing though, so that might be a possible lead as to what's going wrong?
:::Regardless, this bug requires fixing. Having both the element and template used alongside each other in articles will likely just pose problems further down the road, even if it were to work correctly now. I'm not sure where bugs for the Visual Editor should be reported though? <span style="font-family:atkinson hyperlegible">― '''[[User:Wauteurz|Wauteurz]]''' <small>([[User talk:Wauteurz|talk]])</small></span> 21:23, 25 September 2024 (UTC)
::::This would be a feature request, which you can file in [[phab:]]  Add "VisualEditor" as a tag. [[User:WhatamIdoing|WhatamIdoing]] ([[User talk:WhatamIdoing|talk]]) 16:35, 26 September 2024 (UTC)
:::::Wouldn't the fix be as simple as having VE insert the template, and not the element? [[User:Hanyangprofessor2|Hanyangprofessor2]] ([[User talk:Hanyangprofessor2|talk]]) 06:35, 30 September 2024 (UTC)
::::::I think you'd actually have VE make it locally configurable, so that local admins could tell it whether to prefer a template and which template to prefer.  But even simple feature requests are still feature requests. [[User:WhatamIdoing|WhatamIdoing]] ([[User talk:WhatamIdoing|talk]]) 16:36, 30 September 2024 (UTC)

===About districts (and students)===

:[[User:Hanyangprofessor2]], I'm sorry I don't know the answer to this question, but while we're waiting for a more technically savvy person to come along and address it, could you please ask your students not to create new district articles for city districts without starting a discussion on the relevant talk (discussion) page and gaining a consensus that they are needed, not to edit pages like [[Wikivoyage:Small city article template]] and [[Template:Smallcity skeleton]], and also explain that we don't give articles or redirects titles that are in non-Roman scripts? We all know there's a learning curve and appreciate your students' efforts, but knowing these things will help them avoid hassles. Thanks a lot!
:Best,
:[[User:Ikan Kekek|Ikan Kekek]] ([[User talk:Ikan Kekek|talk]]) 08:28, 23 September 2024 (UTC)
::@[[User:Ikan Kekek|Ikan Kekek]] Thanks, I will be revising the assignment now to include this. That said, I think we are way too strict on districts. I mean, I live next to Seoul, most of its districts are larger than your average town or city. A lot of my students are puzzled why we don't have articles on them and I can't really explain it to them. Ex. [[Hyehwa]]. Not that I am opposed to redirecting and merger, if there is little content. Oh, and as for foreign language redirects, I don't see why we don't like them, but they are just unavoidable accidents - a lot of students use automated translation in their browsers (at least one published article today in Chinese...). I am afraid there is not much I can do except moving the articles to correct names when such an error happens (it should not be too often). Btw, [[Jinshazhou]] (K) error was probably due to "Fat finger" and mobile interface (I do require students to bring a laptop, but some still bring tablets, sigh). [[User:Piotrus|Piotrus]] ([[User talk:Piotrus|talk]]) 08:47, 23 September 2024 (UTC)
:::[[Seoul]] has 11 district articles. If that were to be changed, someone would have to change the map, create new maps for new and changed districts, and a whole lot of listings would need to be moved by someone who knows which of the current and new districts they are in. If we were to allow people to unilaterally change the district structure of articles, it would create a huge mess. [[User:Ikan Kekek|Ikan Kekek]] ([[User talk:Ikan Kekek|talk]]) 09:37, 23 September 2024 (UTC)
::::I am not happy with what I think is semi-arbitrary grouping of some districts, but for now I think we can just work on expanding the existing articles and see if and when they get too big and need more splits.  [[User:Piotrus|Piotrus]] ([[User talk:Piotrus|talk]]) 04:11, 24 September 2024 (UTC)
:::::Do feel free to propose a specific new district structure for [[Seoul]] in [[Talk:Seoul]]. That's how these kinds of things get started in the first place and changed later. [[User:Ikan Kekek|Ikan Kekek]] ([[User talk:Ikan Kekek|talk]]) 04:16, 24 September 2024 (UTC)

: For China in particular, districts are problematic. Chinese users often add articles for the official administrative districts, which in general do not work well as WV districts; see [[Talk:Fuzhou#Districts?]] for an example. Also, there's often an ambiguity between city & prefecture; do we need one article, one plus a redirect, or two? I'd say usually just one for the city, but some cases are more complicated; see [[Talk:Dengfeng]] for example. [[User:Pashley|Pashley]] ([[User talk:Pashley|talk]]) 12:45, 23 September 2024 (UTC)
::@[[User:Pashley|Pashley]] Yeah, it's confusing for me, I have students write about city, then add listings for some stuff that seems pretty far away. I guess they are confused about city & prefecture issue too, and I am not sure what to do here. [[User:Piotrus|Piotrus]] ([[User talk:Piotrus|talk]]) 04:12, 24 September 2024 (UTC)
:::I don't know how to explain it to students, but normally you could check the region article for what articles there are, and check whether the city described in yours or one in an already existing other article would be a more convenient base for visiting an attraction. If some such city is a realistic base, then we include the sight there, regardless of whether it is "in" the city (whatever that's taken to mean).
:::Of course, sometimes you want to create new articles to accommodate your points of interest, and then the question arises, whether a place is worth an article and what area the new article should cover. That's often tricky if the official boundaries don't make sense for Wikivoyage.
:::–[[User:LPfi|LPfi]] ([[User talk:LPfi|talk]]) 14:33, 24 September 2024 (UTC)